-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling + consistency when no_std #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2023
tadeohepperle
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
gilescope
reviewed
Jul 29, 2023
gilescope
reviewed
Jul 29, 2023
gilescope
approved these changes
Jul 29, 2023
lexnv
approved these changes
Jul 31, 2023
I'll hold off releasing this until @tadeohepperle your fix is in, because that would be very cool to get out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I standardised no_std errors to be
Display + Debug
, which is closer to the "real"std::error::Error
trait (and is whatserde
does too forno_std
), exposed a couple of helpers to make constructing them from strings simpler (scale-value
andsubxt
use these) and made use ofderive_more
since it's used inscale-value
anyway, and is rather helpful.Also bumped the version ready for a new release once this merges.
Part of a series:
Changes tested against Subxt; I'll update that next.